Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package availability addressed #52

Merged
merged 3 commits into from
Oct 18, 2018
Merged

package availability addressed #52

merged 3 commits into from
Oct 18, 2018

Conversation

taddallas
Copy link
Contributor

Addressed name validation issue #38 by adding available functionality from R package available.

@stephlocke
Copy link
Member

Thanks for a great PR @taddallas I appreciate you adding tests n all! I see a lot of repeated code on the available checks tho and I'm hoping you can abstract this into a util functions (and not exported) that can be used by everything. It may just need to be called from createBasicProject for the others to inherit the capability too saving much code!

@taddallas
Copy link
Contributor Author

Thank you. The first pass was a bit inelegant, as I see now. I've added the function is_available which (I think) follows the naming conventions you've set up (correct me if I'm wrong), and haven't called it when it doesn't need to be called (e.g., in createAnalysisProject).

@stephlocke stephlocke merged commit cc8bb2e into lockedata:master Oct 18, 2018
@stephlocke
Copy link
Member

Thanks @taddallas for the great contribution!

We ship stickers to folks on a monthly basis, so if you'd like us to ship you a laptop sticker, go fill out https://airtable.com/tblYkXKrZmIVIxrqD/viwhMAgnbDW5nCRGx

@stephlocke
Copy link
Member

D'oh - I gave you the wrong link! Sorry @taddallas https://airtable.com/shr31Z5XIyGbbwqFb

@taddallas
Copy link
Contributor Author

😆 No worries. I was wondering why I needed to sign in and ask permission. Thanks for the cool sticker! And great work o the package as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants